Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disallow renote of direct note #11970

Merged
merged 6 commits into from
Oct 5, 2023
Merged

Disallow renote of direct note #11970

merged 6 commits into from
Oct 5, 2023

Conversation

anatawa12
Copy link
Member

@anatawa12 anatawa12 commented Oct 5, 2023 •
edited
Loading

What

Fixes #11969

ダイレクト投稿をRenoteできるのを修正しました

Why

多分想定外

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added packages/frontend Client side specific issue/PR packages/backend Server side specific issue/PR labels Oct 5, 2023
@codecov
Copy link

codecov bot commented Oct 5, 2023 •
edited
Loading

Codecov Report

Attention: 14 lines in your changes are missing coverage. Please review.

Comparison is base (2a7bc84) 79.24% compared to head (6b438fc) 79.22%.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop   #11970      +/-   ##
===========================================
- Coverage    79.24%   79.22%   -0.02%     
===========================================
  Files          928      928              
  Lines        99268    99293      +25     
  Branches      8033     8037       +4     
===========================================
+ Hits         78663    78668       +5     
- Misses       20605    20625      +20
Files Coverage Δ
packages/frontend/src/components/MkNote.vue 100.00% <100.00%> (ø)
...s/backend/src/server/api/endpoints/notes/create.ts 95.65% <64.28%> (-1.43%) ⬇️
packages/backend/src/core/NoteCreateService.ts 90.45% <60.86%> (-0.39%) ⬇️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@anatawa12
Copy link
Member Author

image

@anatawa12
Copy link
Member Author

ready

@syuilo syuilo merged commit ee483f2 into misskey-dev:develop Oct 5, 2023
15 checks passed
@syuilo
Copy link
Member

syuilo commented Oct 5, 2023

🙏

@anatawa12 anatawa12 deleted the direct-note-renote branch October 5, 2023 11:42
kanarikanaru pushed a commit to kanarikanaru/misskey that referenced this pull request Oct 12, 2023
@anatawa12 @kanarikanaru
Disallow renote of direct note (misskey-dev#11970)
79eab26 
* chore: renoteに関するチェックをまとめる

* fix: ダイレクト投稿をrenoteできる

* fix(frontend): 自分のダイレクト投稿をrenoteできる

* docs(changelog): ダイレクト投稿をリノートできてしまう

* fix lint

* chore(backend): visibilityに関するエラーをApi Errorとして返す
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
packages/backend Server side specific issue/PR packages/frontend Client side specific issue/PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ダイレクト投稿をRNできる
2 participants
@anatawa12 @syuilo